Add podAnnotation to medusa operator and reaper operator #1449
Conversation
There was a problem hiding this comment.
Thanks for the PR. Please note that medusa-operator and reaper-operator are no longer actively developed. https://github.com/k8ssandra/k8ssandra-operator is where active development happens. With that said, I am happy to help you with this PR. Feel free to discuss on the K8ssandra as well :)
| @@ -11,6 +11,10 @@ spec: | |||
| template: | |||
| metadata: | |||
| labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
| {{- with .Values.podAnnotations }} | |||
There was a problem hiding this comment.
Shouldn't .podAnnotations be under annotations?
There was a problem hiding this comment.
@jsanda Could you check again? I updated some commits based on your comments.
| @@ -11,6 +11,10 @@ spec: | |||
| template: | |||
| metadata: | |||
| labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
| {{- with .Values.podAnnotations }} | |||
| annotations: | |||
| {{- toYaml . | nindent 8 }} | |||
There was a problem hiding this comment.
This isn't the variable scope you want. It needs to be more narrow.
| @@ -10,6 +10,10 @@ spec: | |||
| template: | |||
| metadata: | |||
| labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
| {{- with .Values.podAnnotations }} | |||
There was a problem hiding this comment.
Same as comments for medusa-operator chart.
omygod613
force-pushed
the
fix/podannotation
branch
from
3c58e42
to
a5d095d
Compare
Thanks for the information. We definitely will migrate our k8ssandra to 2.x in the future. However, so far we are not going to do it recently. Please help me out with this PR. Thanks :)))) |
What this PR does:
Add
annotationsto thedeployment.yamlfor medusa-operator and reaper-operator, so that thepodAnnotationscan be applied to the generateddeployment.yamlWhich issue(s) this PR fixes:
Fixes #
Checklist