Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a signal to proxy all Completer.selected signals #16312

Merged
merged 4 commits into from
May 16, 2024
Merged

Add a signal to proxy all Completer.selected signals #16312

merged 4 commits into from
May 16, 2024

Commits on May 9, 2024

  1. Add Signal to proxy all Completer selected Signals 

    Completer currently emits a signal when a completion is selected.
This surfaces that signal to the CompletionProviderManager, which
then proxies all the Completer signals to the new signal.

This will allow extensions to know when a selection is made in a
Completer. Currently there are edge cases where a selection can be
made without calling a command that can be connected to.

Signed-off-by: Alex Bozarth <[email protected]>
    @ajbozarth
    ajbozarth committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5e2d8cf View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Emit ICompleterSelection instead of string

    @ajbozarth
    ajbozarth committed May 10, 2024
    Configuration menu
    Copy the full SHA
    594a843 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. change text to insertText

    @ajbozarth
    ajbozarth committed May 13, 2024
    Configuration menu
    Copy the full SHA
    814370c View commit details
    Browse the repository at this point in the history

  2. add new test for selected

    @ajbozarth
    ajbozarth committed May 13, 2024
    Configuration menu
    Copy the full SHA
    699df1c View commit details
    Browse the repository at this point in the history