Add a signal to proxy all Completer.selected
signals
#16312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16294
Code changes
Completer
currently emits a signal (_selected
) when a completion is selected. This PR creates a new signal inCompletionProviderManager
, which proxies theCompleter
signal from everyCompletionHandler
that is generated.This will allow extensions to know when a selection is made by any Completer. Currently there are edge cases (as listed in #16294) where a selection can be made without calling a command that can be connected to.