feature: header-click event for reporting clicks within header #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets $FZF_HEADERCLICK_LINE and $FZF_HEADERCLICK_COLUMN env vars with coordinates of last click inside and relative to the header and fires header-click event.
junegunn
reviewed
May 4, 2024
junegunn
reviewed
May 4, 2024
junegunn
reviewed
May 4, 2024
junegunn
reviewed
May 4, 2024
junegunn
reviewed
May 4, 2024
junegunn
reviewed
May 5, 2024
After some testing, I decided that we should not reset the variables.
Because if we do that, the information becomes unavailable to the
preview process as it runs asynchronously in a different goroutine.
fzf --header-lines=2 --bind 'click-header:transform-prompt(printf ${FZF_CLICK_HEADER_LINE}x${FZF_CLICK_HEADER_COLUMN})+preview(env | grep FZF)'
|
Merged, thanks! |
|
Glad to contribute! Thanks |
|
Hmm, I think we should reconsider how to report the line number as it can be confusing when you use multi-line Unlike fzf --header $'1. hello\n2. world' --header-first \
--bind 'click-header:transform-prompt:echo ${FZF_CLICK_HEADER_LINE}x${FZF_CLICK_HEADER_COLUMN}'clicking on But when you're in fzf --header $'1. hello\n2. world' --header-first \
--bind 'click-header:transform-prompt:echo ${FZF_CLICK_HEADER_LINE}x${FZF_CLICK_HEADER_COLUMN}'This gets even more confusing when you use both Should we always count from the top? Let me think about that. |
junegunn
added a commit
that referenced
this pull request
May 6, 2024
Regardless of `--layout`. #3768 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
FZF_HEADERCLICK_LINEandFZF_HEADERCLICK_COLUMNenv vars with coordinates of last click inside and relative to the header and fires header-click event.printf "header1\nheader2\nheader3\na\nb\nc" | fzf --header-lines=3 --bind "header-click:transform-prompt(echo \${FZF_HEADERCLICK_LINE}x\${FZF_HEADERCLICK_COLUMN})"Could be useful for eg. selecting a sort column. Could set a
FZF_HEADERCLICK_WORDvar as well if that is more useful to people.Here is a more complex demo with an interactive keyboard (invoke like
cat /usr/share/dict/words | python keyboard.py).