Count $FZF_CLICK_HEADER_LINE from top to bottom

Regardless of `--layout`. #3768 (comment)
junegunn · May 6, 2024 · bf18444 · bf18444
1 parent 7b98c2c
commit bf18444
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/man/man1/fzf.1 b/man/man1/fzf.1
@@ -1280,7 +1280,7 @@ e.g.
 
 \fIclick-header\fR
 .RS
-Triggered when a mouse click occurs within the header. Sets \fBFZF_CLICK_HEADER_LINE\fR and \fBFZF_CLICK_HEADER_COLUMN\fR environment variables.
+Triggered when a mouse click occurs within the header. Sets \fBFZF_CLICK_HEADER_LINE\fR and \fBFZF_CLICK_HEADER_COLUMN\fR environment variables starting from 1.
 
 e.g.
  \fBprintf "head1\\nhead2" | fzf --header-lines=2 --bind 'click-header:transform-prompt:printf ${FZF_CLICK_HEADER_LINE}x${FZF_CLICK_HEADER_COLUMN}'\fR

diff --git a/src/terminal.go b/src/terminal.go
@@ -4023,31 +4023,26 @@ func (t *Terminal) Loop() {
  }
  }
  return doActions(actionsFor(evt))
- } else {
+ } else if t.headerVisible {
  // Header
- lineOffset := 0
  numLines := t.visibleHeaderLines()
+ lineOffset := 0
  if !t.headerFirst {
  // offset for info line
  if t.noSeparatorLine() {
  lineOffset = 1
  } else {
  lineOffset = 2
  }
- } else {
- // adjust for too-small window
- numItems := t.areaLines - numLines
- if !t.noSeparatorLine() {
- numItems -= 1
- }
- if numItems < 0 {
- numLines += numItems
- }
  }
- my = util.Constrain(my-lineOffset, -1, numLines)
+ my -= lineOffset
  mx -= 2 // offset gutter
  if my >= 0 && my < numLines && mx >= 0 {
- t.clickHeaderLine = my + 1
+ if t.layout == layoutReverse {
+ t.clickHeaderLine = my + 1
+ } else {
+ t.clickHeaderLine = numLines - my
+ }
  t.clickHeaderColumn = mx + 1
  return doActions(actionsFor(tui.ClickHeader))
  }