[Mesh] TriangleMesh's "+=" operator appends UVs regardless of the presence of existing features #6728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows appending of UV coordinates, textures and material IDs with
+=
operator overload inTriangleMesh
class irrespective of the presence of these attributes in the existing mesh (mesh on LHS to += operator)Type
Motivation and Context
The
+=
operator overload ofTriangleMesh
class does not append UV coordinates, textures and material IDs when the existing mesh (mesh on LHS to += operator) already contains any of these attributes. There is no reason to limit+=
for UVs toTriangleMesh
with the attributes already assigned as it currently happens here.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
The current change doesn't check if the presence of UV coordinates, textures and material IDs in the existing mesh and appends only based on their availability in the incoming mesh.
I am attaching a screenshot that shows the addition of UV coordinates based on
+=
operator. The test code is as followsThe following is the resulting mesh with its texture UVs.