Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add last_write_time and table buffer size #25017

Merged
merged 1 commit into from
May 21, 2024
Merged

feat: Add last_write_time and table buffer size #25017

merged 1 commit into from
May 21, 2024

Commits on May 21, 2024

  1. feat: Add last_write_time and table buffer size 

    This adds tracking of the instant of the last write to open buffer segment and methods to the table buffer to compute the estimated memory size of it.

These will be used by a background task that will continuously check to see if tables should be persisted ahead of time to free up buffer memory space.

Originally, I had hoped to have the size tracking happen as the buffer was built so that returning the size would be zero cost (i.e. just returning a value), but I found in different kinds of testing that I wasn't able to get something that was even close to accurate. So for now it will use this more expensive computed method and we'll check on this periodically (every couple of seconds) to see when to persist.
    @pauldix
    pauldix committed May 21, 2024
    Configuration menu
    Copy the full SHA
    506d7ac View commit details
    Browse the repository at this point in the history