feat: Add last_write_time and table buffer size #25017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
reviewed
May 20, 2024
| @@ -231,6 +232,17 @@ impl TableBuffer { | |||
|
|
|||
| Ok(RecordBatch::try_new(schema, cols)?) | |||
| } | |||
|
|
|||
| /// Returns an estimate of the size of this table buffer based on the data and index sizes. | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Why is this here? Is this like that because it's going to be used in a later PR?
There was a problem hiding this comment.
Yeah, the lint was complaining
There was a problem hiding this comment.
Updated with name change to have _ prefix to avoid the lint and removed the allow.
This adds tracking of the instant of the last write to open buffer segment and methods to the table buffer to compute the estimated memory size of it. These will be used by a background task that will continuously check to see if tables should be persisted ahead of time to free up buffer memory space. Originally, I had hoped to have the size tracking happen as the buffer was built so that returning the size would be zero cost (i.e. just returning a value), but I found in different kinds of testing that I wasn't able to get something that was even close to accurate. So for now it will use this more expensive computed method and we'll check on this periodically (every couple of seconds) to see when to persist.
pauldix
force-pushed
the
pd/buffer-memory-size
branch
from
a9c5599
to
506d7ac
Compare
hiltontj
approved these changes
May 21, 2024
mgattozzi
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tracking of the instant of the last write to open buffer segment and methods to the table buffer to compute the estimated memory size of it.
These will be used by a background task that will continuously check to see if tables should be persisted ahead of time to free up buffer memory space.
Originally, I had hoped to have the size tracking happen as the buffer was built so that returning the size would be zero cost (i.e. just returning a value), but I found in different kinds of testing that I wasn't able to get something that was even close to accurate. So for now it will use this more expensive computed method and we'll check on this periodically (every couple of seconds) to see when to persist.
This is the first bit of work for #24956