Faraday connection updated #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60ab359.
Merged
|
@hexgnu I've been running this branch in a production app for a few days with no issues. Only remaining problem is the build failing on |
|
Maybe we should drop rbx support for right now unless someone pipes up? |
|
Agreed, if someone pipes up, then we can revisit |
|
@hexgnu Dropped |
|
This will close #208 |
This was referenced Nov 22, 2014
|
The thread safe fix with Faraday works perfectly ! |
|
@solher Good to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hexgnu I came back and took another look at this. I rebased #212 onto master and made a few fixes. The only notable change is adding the
:ignore_extra_keyswhich fixes SimpleOAuth v0.3.0.How about targeting and #211 this for a 1.1.0 release? I'm going to work on #211 next
Also, I'm going to run this branch in one of our apps for a couple days to verify that its good to go.
Regarding #240, I'm happy to start reviewing the existing PRs and issues and enlisted some other developers here to help (@GaggleAMP) if necessary.