Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deletes update #250

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Remove deletes update #250

wants to merge 28 commits into from

Conversation

hundredwatt
Copy link
Collaborator

I rebased #186 onto #248 (as I'm assuming #248 will be merged soon) and then replaced all delete calls with [] or fetch. However, the issues from #186's description still apply as I used a blacklist to drop parameters from the query string in 75ecf01

hexgnu and others added 28 commits November 11, 2014 18:46
@hexgnu @hundredwatt
First stab at bringing config connection client
bc786ab
@hexgnu @hundredwatt
Verify not verity
1adc6ef
@hexgnu @hundredwatt
Caching locally the connection variable
2c6c0b4
@hexgnu @hundredwatt
Move connection into client
7348501
@hexgnu @hundredwatt
WIP Faraday connection
8a1908d
@hexgnu @hundredwatt
Proof of Concept done minus the weird fields issue
195b64d
@hexgnu @hundredwatt
Take out puts
45c22b0
@hexgnu @hundredwatt
All things passing
3202628
@hexgnu @hundredwatt
Finishing up and giving the ability to add new middleware
ef014d3
@hexgnu @hundredwatt
Take out to_query and to_uri helpers
40f7823
@hexgnu @hundredwatt
Refactor error reporting
80222d1
@hexgnu @hundredwatt
Use mashify instead of Mash.new
7448309
@hexgnu @hundredwatt
Take out whitespace
1043769
@hexgnu @hundredwatt
Cleanup brackets on spec
0064f3a
@hundredwatt
Remove failfast option
065e0a3
@hexgnu @hundredwatt
Raise multi_json to ~>1.8
44362bf
@hundredwatt
Fix SimpleOAuth header generation
4c0a239
@hundredwatt
Match class/file naming convention
301f1bb
@hundredwatt
Update http stubs for #224
95b1131
@hundredwatt
More updates to http stubs and fix Company API cassette
7294454
@hundredwatt
Build against rbx-2 to match Addressable gem
60ab359
@hundredwatt
Revert "Build against rbx-2 to match Addressable gem" - didn't fix build
1db6a0e 
This reverts commit 60ab359.
@hexgnu
Let's try and use a specific version of rbx
617ad8d
@hexgnu
Bump again
d839efa
@hundredwatt
Drop rbx
e669cc6
@hundredwatt
Taking out options mangling for Search
9ab98da
@hundredwatt
Take out group path delete(:id)
271c87f
@hundredwatt
Replace #delete calls with #[] or #fetch
75ecf01 
After rebase #186 onto `faraday_connection_updated` branch (branch for #248)
@hundredwatt
Copy link
Collaborator Author

Sorry for the long PR, only the commits after 9ab98da apply. The others show here because #248 hasn't be merged yet.

@hundredwatt
Copy link
Collaborator Author

Will close #181 and #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hundredwatt @hexgnu