Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance warning adjustments #3942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Performance warning adjustments #3942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/monitor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
bool restore_check = false;
bool hwmon_check = false;
bool performance_check = false;
bool performance_warned = false;

const int sleep_time = 1;
const double exec_low = 50.0; // in ms
const double exec_low = 25.0; // in ms
const double util_low = 90.0; // in percent

if (user_options->runtime)
Expand Down Expand Up @@ -245,7 +246,7 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
}
}

if (performance_check == true)
if (performance_check == true && status_ctx->devices_status == STATUS_RUNNING && performance_warned == false)
{
int exec_cnt = 0;
int util_cnt = 0;
Expand Down Expand Up @@ -285,18 +286,22 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
if (exec_cnt > 0) exec_avg = exec_total / exec_cnt;
if (util_cnt > 0) util_avg = util_total / util_cnt;

if ((exec_avg > 0) && (exec_avg < exec_low))
if (((exec_avg > 0) && (exec_avg < exec_low)) || ((util_avg > 0) && (util_avg < util_low)))
{
performance_warnings++;

if (performance_warnings == 10) EVENT_DATA (EVENT_MONITOR_PERFORMANCE_HINT, NULL, 0);
}

if ((util_avg > 0) && (util_avg < util_low))
else
{
performance_warnings++;
if (performance_warnings > 0)
{
performance_warnings--;
}
}

if (performance_warnings == 10) EVENT_DATA (EVENT_MONITOR_PERFORMANCE_HINT, NULL, 0);
if (performance_warnings == 10)
{
performance_warned = true;
EVENT_DATA (EVENT_MONITOR_PERFORMANCE_HINT, NULL, 0);
}
}

Expand Down