Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance warning adjustments #3942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PenguinKeeper7
Copy link
Contributor

This makes the "Cracking performance lower than expected?" warning more forgiving before displaying. The previous behaviour would trigger if performance dropped at least 10 times over the entire run, checked in 1 second intervals. This means it's almost guaranteed to trigger on longer runs, just by pure chance. This patch makes it so you'd have to fail the kernel time and util checks many times in a short period instead of over the entire run. The counter decreases with every successful check and increases with every failed check instead of only ever increasing.
This patch will also stop checking when Hashcat is [p]aused instead of continuing to check as normal.

Thanks to @roycewilliams finding the pausing issue!

Be more forgiving before displaying a performance warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant