moved resolveJasmine/jasminePromise function to fix scope issue #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
looks fine to me. Just need a CLA signature and I think we are ok. |
|
@TristanNovo will you rebase with master to fix conflicts and sign the cla to get this merged? |
|
@TristanNovo Any update to this? |
|
Someone with a signed cla will probably need to duplicate this behavior. @TristanNovo is not responding. @matthew-dean do you want to take care of it? |
ChrisBoet
added a commit
to ChrisBoet/grunt-contrib-jasmine
that referenced
this pull request
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to issue 299
Upon further inspection I noticed that the function that is awaited until the jasmine tests complete is defined closer to the top of the file where I don't believe it is getting properly reset between multi tasks, causing the strange behavior I observed.
I've simply moved that function definition into the
launchPuppeteerfunction and explicitly pass it into thesetupfunction, and this seems to fix the issue.