grunt-contrib-jasmine: Resolved Jasmine Test Hang Issue

[ossdev07]

Testcases which use grunt-contrib-jasmine are hanging because jasmine doesn't get test status back from the browser.

So added resolve(); in jasmine.js to resolve the jasmine test case hang issue.

[jsf-clabot]

All committers have signed the CLA.

[jabbany]

This doesn't look right since immediately resolve()-ing defeats the purpose of having the jasminePromise in the first place which (I think) ensures that all the tests have run to completion or some failure has occurred.

Suspecting hangs to be related to #300 (or its fix?) but not sure what happened since that PR has not been merged or closed...

[steveoh]

Still waiting on the CLA for #300 #300 (comment)

[jabbany]

Either way it doesn't look like this PR is doing the right thing... resolve()-ing in the promise doesn't make sense.

[steveoh]

So do you want to work with @ossdev07 to make this work or should it be closed?

[jabbany]

I think it's probably a good idea to close this PR. The change doesn't make sense to me as it is, but someone else should probably also review it.

Following that, it may make sense for to @ossdev07 repost this as an issue with more information on the specific symptoms of their hanging tests and general setup to reproduce. I haven't actually encountered any hanging tests on my side (though I have had missed test cases like in #299). It may be the case that their issue isn't actually related to/resolved by the change in #300 which would imply figuring out what the proper fix is.

ossdev07, if you're interested, it would be helpful if you can test incorporating the changes from the PR mentioned above and see if that resolve your hang. If it works, I'd be happy to work with you on getting a fix in.

[ossdev07]

Hi @jabbany as per your suggestion I have tried to incorporate the changes present in the PR #300, but I am facing below issue please have a look and revert:

Running "jasmine:main" (jasmine) task

Testing specs with Jasmine/latest via HeadlessChrome/78.0.3882.0

log: Refused to apply style from 'http://localhost:8081/absolute/something.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

log: Failed to load resource: the server responded with a status of 404 ()

log: start spec
^C

After this, the tests don't proceed further and hangs, I have analyzed the issue and it looks to me that the test-runner-main.html file which I think gets created at runtime through test-runner-template.tmpl is not getting loaded.

It will be helpful if you could provide some pointers.