Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds PlacesClient.awaitIsOpen extension functions #233

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Adds PlacesClient.awaitIsOpen extension functions #233

merged 2 commits into from
Feb 9, 2024

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Feb 8, 2024 •
edited
Loading

  • chore: Update to gradle 8.2.2, kotlin to 1.9.22, hilt to 2.50
  • fix: Adds awaitIsOpen extension functions to the PlacesClient

name: Pull request
about: Create a pull request
label: 'triage me'

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@dkhawk dkhawk requested a review from wangela February 8, 2024 23:35
@dkhawk dkhawk marked this pull request as ready for review February 8, 2024 23:36
kikoso
kikoso approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkhawk dkhawk merged commit 99ba60f into main Feb 9, 2024
9 checks passed
@dkhawk dkhawk deleted the dkhawk/places-3.1.0-extensions branch February 9, 2024 17:36
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 3.2.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoso kikoso kikoso approved these changes

@wangela wangela Awaiting requested review from wangela

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dkhawk @googlemaps-bot @kikoso @wangela