Drop CountsAndLists Data from the Fleet and Game Server Set When the Flag is False #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er set Status if the flag has been turned off
zmerlynn
approved these changes
Jun 25, 2024
|
Build Succeeded 👏 Build Id: 5dea7515-6cfc-4562-b523-1c303d1d7a22 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
When the CountsAndLists FeatureGate is turned from on (true) to off (false) during a
helm upgrade, the Fleet and Game Server Set stop aggregating CountsAndLists data. However, they currently still show (kubectl describe fleetorkubectl describe gss) the old static AggregatedCounterStatus and AggregatedListStatus from before the flag was turned off.This PR drops the AggregatedCounterStatus and AggregatedListStatus from the Fleet and Game Server Set Status when the FeatureGate CountsAndLists is turned off. The Status will be recalculated if the flag is turned back on.
Which issue(s) this PR fixes:
Working on In-place Agones Upgrades: Storage Compatibility #3771
Special notes for your reviewer: