Add installation of MuJoCo plugins as part of CMake installation logic #1515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users in my lab found confusing the fact that
simulate
did not found the plugins out of the box if mujoco was built from source, and apparently also other users had the same confusion (see for example #723 (comment)).This PR hopefully simplifies this by also installing as part of the CMake install step the mujoco plugins in
${CMAKE_INSTALL_PREFIX}/bin/mujoco_plugin
, exactly wheresimulate
expects to find them, and where they are placed in the official release binaries.At the moment, I did not include this modifications for the case in which
MUJOCO_BUILD_MACOS_FRAMEWORKS
isON
, as it is not really clear to me how this should be handled. However, when building by sourceMUJOCO_BUILD_MACOS_FRAMEWORKS
is set toOFF
, so for all users that build from source, this PR ensure that the installedsimulate
will be able to find all the mujoco plugins out of the box.fyi @francesco-romano