Solve problem with deleting filtered activities #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er applied it deletes all the activites and not the ones that are filtered \
GerardPolloRebozado
changed the title
|
Could you please resolve the conflicts before the code review? Thank you very much! |
dtslvr
requested changes
May 11, 2024
apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
Outdated
Show resolved
Hide resolved
|
Applied what your said in the comments but now you can't delete orders using filters due to #3389 |
dtslvr
requested changes
May 11, 2024
There was a problem hiding this comment.
Applied what your said in the comments but now you can't delete orders using filters due to #3389
You can remove this line to enable it: https://github.com/ghostfolio/ghostfolio/pull/3389/files#diff-c194725360f0243d507099d20e31d9c13c4c828d1c801eb5ae64b6518fbf795fR404
dtslvr
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves a problem where deleting all activities while having a filter applied would delete all activities instead of just the ones that are filtered. The issue has been fixed by adding filters to the deleteOrders method in the OrderController and OrderService classes. Now, only the filtered activities will be deleted.