Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend DELETE /api/v1/order by filters #3390

Closed
dtslvr opened this issue May 9, 2024 · 2 comments · Fixed by #3394
Closed

Extend DELETE /api/v1/order by filters #3390

dtslvr opened this issue May 9, 2024 · 2 comments · Fixed by #3394
Assignees
@GerardPolloRebozado
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dtslvr
Copy link
Member

dtslvr commented May 9, 2024

Add support for filters (@Query) to the DELETE /api/v1/order endpoint:

  • filterByAccounts
  • filterByAssetClasses
  • filterByTags

Example: https://github.com/ghostfolio/ghostfolio/blob/main/apps/api/src/app/order/order.controller.ts#L87
@dtslvr dtslvr added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 9, 2024
@GerardPolloRebozado
Copy link
Contributor

I can work in that

@GerardPolloRebozado
Copy link
Contributor

Just made a PR: #3394

@dtslvr dtslvr linked a pull request May 10, 2024 that will close this issue
Solve problem with deleting filtered activities #3394
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerardPolloRebozado GerardPolloRebozado

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve problem with deleting filtered activities GerardPolloRebozado/ghostfolio
2 participants
@dtslvr @GerardPolloRebozado