Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounding box sensor #1813

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add bounding box sensor #1813

wants to merge 3 commits into from

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

This PR introduces the semantic image for the door/drawer handle. It uses markers and 3D projection to create bounding boxes.

How Has This Been Tested

Running interative_play.py to view the effect

open_drawer_bounding_box

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 21, 2024
@jimmytyyang jimmytyyang requested review from ASzot, xavierpuigf, zephirefaith and aclegg3 and removed request for ASzot February 21, 2024 00:56
@zephirefaith
Copy link
Contributor

Thanks for the PR, Jimmy! The video is pretty cool too. I added my comments, mostly nits and some code reorg suggestions.
Curious how would this work if I need location of all handles in view (to emulate real-world scenario with a handle detector).

Copy link
Contributor

@zephirefaith zephirefaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just a nit. Thank you for the PR Jimmy :)

habitat-lab/habitat/utils/geometry_utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants