Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Spot leg animation #1748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BE] Spot leg animation #1748

wants to merge 2 commits into from

Conversation

jimmytyyang
Copy link
Contributor

@jimmytyyang jimmytyyang commented Jan 11, 2024

Motivation and Context

In the P0 demo and hab3 paper, we use leg animation to simulate Spot walking behavior. However, such a feature was never merged into the main. In addition, we receive a hab3 user request to add leg animation here: #1721

How Has This Been Tested

Run interactive play to visually verify the correctness

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 11, 2024
@jimmytyyang
Copy link
Contributor Author

*the checkpoint of leg animation was uploaded when we did P0 demo

Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for building this. I have a few design comments.
I feel we could either:

  1. Push this down into the Spot code
    or
  2. Make it a bit more generic for animating legged robots

animate_leg: bool = False
# Leg animation checkpoint file
leg_animation_checkpoint: str = (
"data/robots/spot_data/spot_walking_trajectory.csv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from? Is it hosted on HF?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aclegg3 : If it helps, I found the file present in the below merge request and was able to run the leg animation successfully -

#1554

@ruddradev
Copy link

I found the working code present in the below merge request and was able to run the leg animation successfully -

#1554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants