Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: version selectors synchronization #18260

Merged
merged 4 commits into from Apr 4, 2024
Merged

docs: version selectors synchronization #18260

merged 4 commits into from Apr 4, 2024

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Apr 3, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes #18229

Documentation & Build related.

What changes did you make? (Give an overview)

  • Support vNN.x banches
  • Fetch versions from the main branch on GitHub
  • Update data on each release
  • Trigger rebuilds of docs sites.

Is there anything you'd like reviewers to focus on?

Changes in docs/ should be ported to the v8.x branch. Then, the latest branch should be updated.

Question: What shall we do with eslint.org/docs/next/ when we release v9 final? Keep it or remove it?

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit e43d890
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660d82c306c033000813bbf9

@mdjermanovic mdjermanovic added build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 3, 2024
@github-actions github-actions bot removed the documentation Relates to ESLint's documentation label Apr 3, 2024
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 3, 2024
@github-actions github-actions bot added github actions and removed documentation Relates to ESLint's documentation labels Apr 3, 2024
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 3, 2024
@mdjermanovic mdjermanovic marked this pull request as ready for review April 3, 2024 17:28
@mdjermanovic mdjermanovic requested a review from a team as a code owner April 3, 2024 17:28
@nzakas
Copy link
Member

nzakas commented Apr 3, 2024

Question: What shall we do with eslint.org/docs/next/ when we release v9 final? Keep it or remove it?

I think we should redirect it to /docs/latest.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and a lot more straightforward than what we've been doing.

Just leaving open a couple days to give others a chance to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process documentation Relates to ESLint's documentation github actions
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Permanent solution for multiple docs sites
2 participants