Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: version selectors synchronization #18265

Merged
merged 1 commit into from
Apr 4, 2024
Merged

docs: version selectors synchronization #18265

merged 1 commit into from
Apr 4, 2024

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Apr 4, 2024

This intentionally targets the v8.x branch.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Ports #18260 to v8.x.

What changes did you make? (Give an overview)

Copied docs/ changes from #18260.

Build-related changes are intentionally omitted as they're not important for this branch.

The following code is also intentionally omitted as it was necessary only for testing of #18260 (I'll remove it from the main branch as well):

// For initial commit purpose only
if (items.length === 0) {
const localData = require("./versions.json");
items.push(...localData.items);
}

The same for docs/src/_data/versions.json.

Is there anything you'd like reviewers to focus on?

If we'll release another prerelease this week, I'll manually sync the latest branch with the v8.x branch when this is merged. - edit: no need for updating the latest branch manually as we're releasing v9.0.0 final and the latest branch will be synced with the main branch where this has already been implemented.

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 4, 2024 19:38
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 6c93e8b
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660f01b0abc06d00084fad99
😎 Deploy Preview https://deploy-preview-18265--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 4, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just leaving open so @mdjermanovic can merge when ready.

@mdjermanovic
Copy link
Member Author

Safe to merge now, and we'll need this to test eslint/eslint.org#541.

@mdjermanovic mdjermanovic merged commit c68c07f into v8.x Apr 4, 2024
20 checks passed
@mdjermanovic mdjermanovic deleted the v8-issue18229 branch April 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants