New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable docs/v8.x
#541
Conversation
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What to check: https://deploy-preview-541--new-eslint.netlify.app/docs/v8.x/ should look normal, except that the version in selectors is empty as this is not an "officially" published docs site yet. When we release the v9.0.0 final tomorrow, v8.57.0 will be selected. |
@@ -20,6 +20,7 @@ locals: | |||
docs_latest: latest--docs-eslint.netlify.app | |||
docs_head: docs-eslint.netlify.app | |||
docs_next: next--docs-eslint.netlify.app | |||
docs_v8: v8-x--docs-eslint.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the dot in the branch name, the subdomain on Netlify is v8-x--docs-eslint.netlify.app
, not v8.x--docs-eslint.netlify.app
.
I think it's okay to merge this once approved (i.e., I think merging doesn't have to wait for the v9.0.0 release) so that we can check it live on eslint.org. |
Prerequisites checklist
What is the purpose of this pull request?
Updates the redirects file to enable
/docs/v8.x/
, where we'll have v8.57.0 docs.What changes did you make? (Give an overview)
Copy-pasted and adjusted the code that handles
/docs/head/
.Related Issues
eslint/eslint#18229
Is there anything you'd like reviewers to focus on?