Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable docs/v8.x #541

Merged
merged 2 commits into from Apr 5, 2024
Merged

feat: enable docs/v8.x #541

merged 2 commits into from Apr 5, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Updates the redirects file to enable /docs/v8.x/, where we'll have v8.57.0 docs.

What changes did you make? (Give an overview)

Copy-pasted and adjusted the code that handles /docs/head/.

Related Issues

eslint/eslint#18229

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/660f275522d0700008ee5b35
😎 Deploy Preview https://deploy-preview-541--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/660f27559e7288000743b3b3
😎 Deploy Preview https://deploy-preview-541--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/660f2755234ba70008aa6e9a
😎 Deploy Preview https://deploy-preview-541--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/660f2755c8dd5300086f8b28
😎 Deploy Preview https://deploy-preview-541--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/660f27559f058000081d2d60
😎 Deploy Preview https://deploy-preview-541--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/660f27550d5dad0008d68464
😎 Deploy Preview https://deploy-preview-541--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/660f275502f37900073284f4
😎 Deploy Preview https://deploy-preview-541--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 81a3218
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/660f27552d85a30007987654
😎 Deploy Preview https://deploy-preview-541--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic
Copy link
Member Author

What to check: https://deploy-preview-541--new-eslint.netlify.app/docs/v8.x/ should look normal, except that the version in selectors is empty as this is not an "officially" published docs site yet. When we release the v9.0.0 final tomorrow, v8.57.0 will be selected.

@@ -20,6 +20,7 @@ locals:
docs_latest: latest--docs-eslint.netlify.app
docs_head: docs-eslint.netlify.app
docs_next: next--docs-eslint.netlify.app
docs_v8: v8-x--docs-eslint.netlify.app
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the dot in the branch name, the subdomain on Netlify is v8-x--docs-eslint.netlify.app, not v8.x--docs-eslint.netlify.app.

@mdjermanovic mdjermanovic marked this pull request as ready for review April 4, 2024 22:34
@mdjermanovic
Copy link
Member Author

I think it's okay to merge this once approved (i.e., I think merging doesn't have to wait for the v9.0.0 release) so that we can check it live on eslint.org.

@nzakas nzakas merged commit c8411a2 into main Apr 5, 2024
37 checks passed
@nzakas nzakas deleted the docs-v8.x branch April 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants