Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the time tracking method to accurately track time taken #1176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Malikbadmus
Copy link
Contributor

Description

The time tracking method in use does not accurately depicts the time taken in a model run

Changes made

  • Introduce an update_total_time method in tracking.py to get an accurate measure of time across the two (2) process, minus the time spent waiting for user input(for the CLI).
  • Track time in serve.py.
  • Track time in run.py.

Status

  • A time value that reflects and depicts the total time taken for our model to run.

Related to #1090

@Malikbadmus
Copy link
Contributor Author

@DhanshreeA , how the session file looks like with the changes.

2024-06-26_22-35-59.txt

@DhanshreeA
Copy link
Member

Description

The time tracking method in use does not accurately depicts the time taken in a model run

Changes made

* Introduce an `update_total_time` method in `tracking.py` to get an accurate measure of time across the two (2) process, minus the time spent waiting for user input(for the CLI).

* Track time in `serve.py`.

* Track time in `run.py`.

Status

* A time value that reflects and depicts the total time taken for our model to run.

Related to #1090

I'm a bit confused, how do you think the current implementation does not correctly reflect the time taken?

@Malikbadmus
Copy link
Contributor Author

Description
The time tracking method in use does not accurately depicts the time taken in a model run
Changes made

* Introduce an `update_total_time` method in `tracking.py` to get an accurate measure of time across the two (2) process, minus the time spent waiting for user input(for the CLI).

* Track time in `serve.py`.

* Track time in `run.py`.

Status

* A time value that reflects and depicts the total time taken for our model to run.

Related to #1090

I'm a bit confused, how do you think the current implementation does not correctly reflect the time taken?

I noticed while running test yesterday, i believe the time taken value we are interested in is the time taken to run a model, but we are only tracking the time used in the track method which does not reflect this, we are always getting nanoseconds even when the models take longer to serve and run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants