Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annoying debug logs #1177

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

Malikbadmus
Copy link
Contributor

Description

During a GitHub Actions workflow or when fetching on a system without BentoML installed, BentoML is automatically installed using the command git clone --filter=blob:none --quiet https://github.com/ersilia-os/bentoml-ersilia.git /tmp/pip-req-build-4zsvpc12 , BentoML services are then listed and saved in a catalog, a debug method was used to output this catalog before the services apart from the latest one are deleted during fetching.

Changes made

  • Debug statement deleted.

Status

Code does not appear in git action anymore.

Closes #1080

@DhanshreeA
Copy link
Member

DhanshreeA commented Jun 27, 2024

@Malikbadmus I need some time to go through your other PR #1176 so in the meantime, could you update this branch to be against master (so just to have the one line change and nothing else) and not your other branch? I wish to merge this PR first. Hope that's okay!

@Malikbadmus
Copy link
Contributor Author

Malikbadmus commented Jun 27, 2024

@Malikbadmus I need some time to go through your other PR #1176 so in the meantime, could you update this branch to be against master (so just to have the one line change and nothing else) and not your other branch? I wish to merge this PR first. Hope that's okay!

oh, sorry for that, I have done as suggested

@DhanshreeA DhanshreeA merged commit fac9f2d into ersilia-os:master Jun 27, 2024
16 checks passed
@Malikbadmus Malikbadmus deleted the bentoml branch June 27, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Annoying debug logs making it hard to discern what's happening
2 participants