Combine the GitHub workflows for pull requests. #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
changed the title
|
It's best to organize GitHub workflows so that there's one per trigger (for us that will be pull request and cron) and then have several jobs within each workflow. These changes are stacked on #1585 and must land afterwards. |
motlin
changed the title
motlin
force-pushed
the
maven-config
branch
2 times, most recently
from
b491c85
to
2c99ae8
Compare
donraab
requested changes
May 21, 2024
| distribution: 'zulu' | ||
| java-version: 11 | ||
| - name: JavaDoc Aggregate | ||
| run: ./mvnw -Dsurefire.useFile=false -DskipTests -Denforcer.skip=true clean install javadoc:aggregate --projects '!unit-tests,!serialization-tests,!jcstress-tests,!junit-trait-runner,!unit-tests-java8,!test-coverage,!p2-repository,!org.eclipse.collections:org.eclipse.collections' |
There was a problem hiding this comment.
@motlin , you changed from -pl to --projects for both run commands here.
.github/workflows/pull-request.yml
Outdated
| - run: mvn --non-recursive wrapper:wrapper -Dmaven=3.9.6 | ||
| - run: java --version | ||
| - name: Javadoc | ||
| run: ./mvnw -Dsurefire.useFile=false -DskipTests -Denforcer.skip=true clean install javadoc:aggregate -pl '!unit-tests,!serialization-tests,!jcstress-tests,!junit-trait-runner,!unit-tests-java8,!test-coverage,!p2-repository,!org.eclipse.collections:org.eclipse.collections' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Before:
After: