Add maven profiles and caching to speed up builds. #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
force-pushed
the
maven-profiles-caching
branch
3 times, most recently
from
3e67bb2
to
77b2a83
Compare
motlin
force-pushed
the
maven-profiles-caching
branch
3 times, most recently
from
ef16c7b
to
2ad4ef3
Compare
motlin
commented
May 22, 2024
| @@ -468,7 +386,7 @@ | |||
| <includes> | |||
| <include>**/*Test.java</include> | |||
| </includes> | |||
| <argLine>-XX:-OmitStackTraceInFastThrow -Xms1024m -Xmx2048m @{argLine}</argLine> | |||
| <argLine>-XX:-OmitStackTraceInFastThrow -Xms1024m -Xmx2048m --add-opens java.base/java.lang=ALL-UNNAMED @{argLine}</argLine> | |||
There was a problem hiding this comment.
This bit was a surprise to me. Jacoco must have been doing this on our behalf. Without this, unit tests and serialization tests started to fail in Java 17 and higher when calling clone().
|
Before: After: 
|
motlin
force-pushed
the
maven-profiles-caching
branch
2 times, most recently
from
d4ef310
to
731ecbd
Compare
motlin
force-pushed
the
maven-profiles-caching
branch
from
731ecbd
to
01a1b0b
Compare
motlin
force-pushed
the
maven-profiles-caching
branch
from
01a1b0b
to
bfbbf49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two changes here:
These are only related in that they both are intended to speed up the build and they both were created by comparing with another open source GitHub workflow which is written in this style.
The maven profile thing creates a third related change, splitting the "test" configuration into separate test, enforcer, and dependency:analyze-only jobs.
If this is too much, I can definitely split out the caching, and possibly more.