Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub actions #387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexpott
Copy link
Contributor

@alexpott alexpott commented Oct 6, 2021

Move away from travis to make testing on different PHP versions simpler and better integration with github. This will allow us to add PHP 8.1 testing in #384

@alexpott
Copy link
Contributor Author

alexpott commented Oct 6, 2021

You can see the actions in action here - https://github.com/alexpott/easyrdf/actions/runs/1311440366

@alexpott alexpott mentioned this pull request Oct 6, 2021
@osma
Copy link
Contributor

osma commented Jan 24, 2022

Great work! Much appreciation!

You could consider adding PHP 8.1 tests here as well in experimental mode (allowed to fail with continue-on-error enabled just for that version), like this:

strategy:
  matrix:
    php: [ '7.1', '7.2', '7.3', '7.4', '8.0' ]
    experimental: [false]
    include:
       - php: '8.1'
         experimental: true
  fail-fast: false
  continue-on-error: ${{ matrix.experimental }}

This would highlight the errors encountered with PHP 8.1 without breaking the build. Then the experimental rule can be again dropped in PR #384 (but perhaps reintroduced later when 8.2 is released...)

But this is no big deal - simply merging this first and then merging PR #384 (with PHP 8.1 added to the matrix) as you suggested would give the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants