PHP 8.1 compatibility #384

alexpott · 2021-08-24T14:12:59Z

~~Built on top of #383~~ rebased on top of main now contains only PHP 8.1 changes.

alexpott · 2021-08-24T14:53:11Z

So none of the nightly php builds on travis are php 8.1 ... ho hum. So let's not pretend... here's the output from running the tests locally on PHP 8.1

$ COMPOSER_FLAGS="--no-ansi --no-interaction --ignore-platform-reqs" make -e test-lib
/usr/local/php5/bin/php composer.phar --no-ansi --no-interaction --ignore-platform-reqs install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package zendframework/zend-escaper is abandoned, you should avoid using it. Use laminas/laminas-escaper instead.
Package zendframework/zend-http is abandoned, you should avoid using it. Use laminas/laminas-http instead.
Package zendframework/zend-loader is abandoned, you should avoid using it. Use laminas/laminas-loader instead.
Package zendframework/zend-stdlib is abandoned, you should avoid using it. Use laminas/laminas-stdlib instead.
Package zendframework/zend-uri is abandoned, you should avoid using it. Use laminas/laminas-uri instead.
Package zendframework/zend-validator is abandoned, you should avoid using it. Use laminas/laminas-validator instead.
Generating autoload files
44 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
mkdir -p reports
/usr/local/php5/bin/php -d memory_limit=1G vendor/bin/phpunit -c config/phpunit.xml --testsuite "EasyRdf Library"
PHPUnit 9.5.8 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

.............................................................   61 / 1363 (  4%)
.............................................................  122 / 1363 (  8%)
.............................................................  183 / 1363 ( 13%)
.............................................................  244 / 1363 ( 17%)
.............................................................  305 / 1363 ( 22%)
.............................................................  366 / 1363 ( 26%)
.....................................................S.......  427 / 1363 ( 31%)
.........I...................................................  488 / 1363 ( 35%)
.............................................................  549 / 1363 ( 40%)
.............................................................  610 / 1363 ( 44%)
.............................................................  671 / 1363 ( 49%)
.........................................................SSSS  732 / 1363 ( 53%)
SS...............I...........................................  793 / 1363 ( 58%)
..........I................................................I.  854 / 1363 ( 62%)
.....II...............................................I.....I  915 / 1363 ( 67%)
IIIIII.......................................................  976 / 1363 ( 71%)
...I......................................................... 1037 / 1363 ( 76%)
............................................................. 1098 / 1363 ( 80%)
..........................SSSSSSSSSSSSSSS.................... 1159 / 1363 ( 85%)
..SSS........................................................ 1220 / 1363 ( 89%)
............................................................. 1281 / 1363 ( 93%)
............................................................. 1342 / 1363 ( 98%)
.....................                                         1363 / 1363 (100%)

Time: 00:02.014, Memory: 194.06 MB

OK, but incomplete, skipped, or risky tests!
Tests: 1363, Assertions: 2663, Skipped: 25, Incomplete: 15.

$ php -v
PHP 8.1.0-dev (cli) (built: Aug 21 2021 00:33:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.0-dev, Copyright (c), by Zend Technologies

lib/Http/Response.php

(cherry picked from commit d9f55cb1b9822ada5231bf19fdf0f15a8c848615)

alexpott · 2021-09-01T09:56:52Z

lib/Collection.php

@@ -73,6 +73,7 @@ public function __construct($uri, $graph)
 * @throws \OutOfBoundsException
 * @throws \InvalidArgumentException
 */
+ #[\ReturnTypeWillChange]


This annotation allows us to suppress a deprecation notice triggered by PHP 8.1 - it will require fixing once PHP 9 is released. Since PHP 7.1 is the minimum version we could choose to add the return types here. I went the annotation route because changing or adding a return type should have a new major as per semver.

alexpott · 2021-09-01T09:57:31Z

lib/Format.php

@@ -267,7 +267,7 @@ public static function guessFormat($data, $filename = null)
 }

 // Then try and guess by the first 1024 bytes of content
- $short = substr($data, 0, 1024);
+ $short = substr($data ?? '', 0, 1024);


One of the main PHP 8.1 is that built-in function that use to accept NULLs in string arguments will now trigger a deprecation.

alexpott · 2021-09-01T09:58:20Z

lib/Resource.php

@@ -199,10 +199,10 @@ public function htmlLink($text = null, $options = array())
 );
 }

- $html .= " ".htmlspecialchars($key)."=\"".
- htmlspecialchars($value)."\"";
+ $html .= " ".htmlspecialchars($key, ENT_COMPAT)."=\"".


See https://php.watch/versions/8.1/html-entity-default-value-changes - adding ENT_COMPAT preserves the current behaviour.

alexpott · 2021-09-01T09:59:32Z

test/EasyRdf/GraphTest.php

@@ -167,7 +167,7 @@ public function testParseFileRelativeUri()

 $doc = $graph->get('foaf:PersonalProfileDocument', '^rdf:type');
 $this->assertClass('EasyRdf\Resource', $doc);
- $this->assertRegExp('|^file://.+/fixtures/foaf\.rdf$|', $doc->getUri());
+ $this->assertMatchesRegularExpression('|^file://.+/fixtures/foaf\.rdf$|', $doc->getUri());


The assertRegExp is deprecated in PHPUnit - the polyfill allows us to use the current method when running tests on the older versions of PHPUnit.

alexpott · 2021-09-21T09:02:51Z

@njh PHP 8.1 has now hit RC2. It'd be great to land this and get a new release out so that projects that have EasyRDF as a dependency can have a stable release when PHP 8.1 lands.

alexpott · 2021-10-06T10:10:42Z

@njh PHP 8.1 has hit rc3 :)

alexpott · 2021-10-06T10:23:10Z

@njh I've created #387 to make it easier to add PHP 8.1 testing - if that's merged before this one then I can add PHP 8.1 testing here.

bircher · 2022-01-12T14:14:26Z

I don't know if I should open a new PR, but I found another php 8.1 deprecation warning, fixed similar to this PR, this is the change:

diff --git a/lib/Sparql/Client.php b/lib/Sparql/Client.php
index e12d089..424755f 100644
--- a/lib/Sparql/Client.php
+++ b/lib/Sparql/Client.php
@@ -71,7 +71,7 @@ class Client
     {
         $this->queryUri = $queryUri;
 
-        if (strlen(parse_url($queryUri, PHP_URL_QUERY)) > 0) {
+        if (strlen(parse_url($queryUri, PHP_URL_QUERY) ?? '') > 0) {
             $this->queryUri_has_params = true;
         } else {
             $this->queryUri_has_params = false;

alexpott · 2022-01-12T16:39:54Z

@bircher I'll add it to this PR given a minute.

claudiu-cristea · 2022-02-19T17:20:52Z

@njh, any chance to see this committed?

dunglas

LGTM

renderpci · 2022-12-07T20:14:40Z

Hi everyone

Any changed? it's ready? PHP will update to 8.2 tomorrow... and esayRDF will not work with this version...

Thanks!

zozlak · 2022-12-09T14:20:07Z

@renderpci we have three (sic!) pull requests for making EasyRdf compatible with the PHP 8.1 just the last @njh's activity was 16 months ago and he's the only person with pull request merging rights.

I'm afraid this constitutes an abandoned project.

For a supported fork please take a look a the @k00ni's one - https://github.com/sweetrdf/easyrdf.
If you're interested in support for quads/RDF star/SPARQL star/PSR 7/PSR 18 etc. you may take a look at the rdf interface libraries ecosystem.

longwave reviewed Aug 25, 2021

View reviewed changes

lib/Http/Response.php Outdated Show resolved Hide resolved

alexpott added 4 commits September 1, 2021 10:51

Add annotations to indicate return type will change

b0cf417

(cherry picked from commit d9f55cb1b9822ada5231bf19fdf0f15a8c848615)

Runtime changes for PHP 8.1 compatibility

0b098c9

Test changes for PHP 8.1

94aac14

Remove blank line (thanks @longwave)

b9baef8

alexpott force-pushed the php8.1-compatibility+php8-testing branch from d336b02 to b9baef8 Compare September 1, 2021 09:53

alexpott changed the title ~~PHP 8.1 compatibility + Testing on PHP 8.1~~ PHP 8.1 compatibility Sep 1, 2021

alexpott commented Sep 1, 2021

View reviewed changes

alexpott mentioned this pull request Oct 6, 2021

Move to GitHub actions #387

Open

osma mentioned this pull request Jan 24, 2022

Support PHP 8.0 NatLibFi/Skosmos#1266

Merged

3 tasks

This was referenced Feb 8, 2022

[PhpUnitBridge] Indirect deprecations from PHP 8.1 incorrectly reported as direct deprecations symfony/symfony#45345

Closed

ci: add PHP 8.1 api-platform/schema-generator#364

Merged

osma mentioned this pull request Feb 16, 2022

Tests fail on PHP 8.1 NatLibFi/Skosmos#1274

Closed

dunglas approved these changes Mar 25, 2022

View reviewed changes

k00ni mentioned this pull request Aug 24, 2022

Issue #390: Add return types to be compatible with php 8.1. #398

Closed

claudiu-cristea mentioned this pull request Sep 4, 2022

Issue #390: Fix 8.1 deprecation warnings. #397

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.1 compatibility #384

PHP 8.1 compatibility #384

alexpott commented Aug 24, 2021 •

edited

alexpott commented Aug 24, 2021

alexpott Sep 1, 2021

alexpott Sep 1, 2021

alexpott Sep 1, 2021

alexpott Sep 1, 2021

alexpott commented Sep 21, 2021

alexpott commented Oct 6, 2021

alexpott commented Oct 6, 2021

bircher commented Jan 12, 2022

alexpott commented Jan 12, 2022

claudiu-cristea commented Feb 19, 2022

dunglas left a comment

renderpci commented Dec 7, 2022

zozlak commented Dec 9, 2022

PHP 8.1 compatibility #384

Are you sure you want to change the base?

PHP 8.1 compatibility #384

Conversation

alexpott commented Aug 24, 2021 • edited

alexpott commented Aug 24, 2021

alexpott Sep 1, 2021

Choose a reason for hiding this comment

alexpott Sep 1, 2021

Choose a reason for hiding this comment

alexpott Sep 1, 2021

Choose a reason for hiding this comment

alexpott Sep 1, 2021

Choose a reason for hiding this comment

alexpott commented Sep 21, 2021

alexpott commented Oct 6, 2021

alexpott commented Oct 6, 2021

bircher commented Jan 12, 2022

alexpott commented Jan 12, 2022

claudiu-cristea commented Feb 19, 2022

dunglas left a comment

Choose a reason for hiding this comment

renderpci commented Dec 7, 2022

zozlak commented Dec 9, 2022

alexpott commented Aug 24, 2021 •

edited