[hotfix] set enforce-index-use default value to strict #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naturally, this PR would require a new major release. Today, this would mean it could be a candidate for eXist 7. So I'll set it for that milestone. |
|
Tests will follow shortly... |
reinhapa
requested changes
May 3, 2023
.../indexes/indexes-integration-tests/src/test/java/org/exist/indexing/EnforceIndexUseTest.java
Outdated
Show resolved
Hide resolved
.../indexes/indexes-integration-tests/src/test/java/org/exist/indexing/EnforceIndexUseTest.java
Outdated
Show resolved
Hide resolved
.../indexes/indexes-integration-tests/src/test/java/org/exist/indexing/EnforceIndexUseTest.java
Outdated
Show resolved
Hide resolved
marmoure
force-pushed
the
enforce-index-use
branch
from
a1101a9
to
0da7071
Compare
reinhapa
requested changes
May 5, 2023
.../indexes/indexes-integration-tests/src/test/java/org/exist/indexing/EnforceIndexUseTest.java
Outdated
Show resolved
Hide resolved
reinhapa
approved these changes
May 11, 2023
|
@marmoure Thank you for this PR and adding the tests! |
marmoure
force-pushed
the
enforce-index-use
branch
5 times, most recently
from
3a63c4a
to
e8c9b5f
Compare
marmoure
force-pushed
the
enforce-index-use
branch
from
e8c9b5f
to
76ef533
Compare
marmoure
force-pushed
the
enforce-index-use
branch
from
76ef533
to
d1781dc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
marmoure
added a commit
to evolvedbinary/exist
that referenced
this pull request
May 15, 2023
…t `enforce-index-use` policy for all tests in eXist-db to `strict` also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4884
As discussed in #4884 we want to make the default value to be
strict.This open source contribution to the exist project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.