Prevent omission of results from collections with different index styles #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizzzz
changed the title
dizzzz
reviewed
Apr 17, 2023
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
adamretter
requested changes
Apr 18, 2023
exist-core/src/main/java/org/exist/xquery/pragmas/Optimize.java
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/test/xquery/range/multi-collection-search.xqm
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
|
nice work! |
reinhapa
approved these changes
May 16, 2023
|
The build is failing for now, once #4924 is merged the build will return to normal |
marmoure
force-pushed
the
fix/3620
branch
6 times, most recently
from
c7bb48b
to
26f47f3
Compare
|
SonarCloud Quality Gate failed. |
|
@marmoure please could you rebase? |
adamretter
force-pushed
the
fix/3620
branch
3 times, most recently
from
66dd907
to
60fa4ec
Compare
…ot just those that have a collection.xconf that uses the newer Lucene based Range Index Closes eXist-db#3620
…ith a variety of indexes
…ion in favour of newer Optimizable#canOptimizeSequence(Sequence) function
|
SonarCloud Quality Gate failed.
|
adamretter
changed the title
|
@dizzzz I think this one is ready to land now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3620
When performing a Search on a parent collection that has several sub-collections each with different types of indexes configured, The optimizer was optimizing the query without checking if all sub-collections were fit to be optimized.
#3620 has a nice test suit to illustrate this issue thanks to @joewiz. This PR now passes all of those tests.
This open source contribution to the exist project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.