Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/tools/jupyter) Add --directory flag to control where jupyter kernelspec installs #23595

Closed
wants to merge 6 commits into from

Commits on Apr 28, 2024

  1. feat(cli/tools/jupyter) Add --directory flag to control where kernels…

    …pec installs
    
    Closes: denoland#20744
    
    Adds ability to specify the kernelspec location for deno kernel with
    --directory flag
    
    Continued default behavior installs in user's kernelspec folder via
    jupyter shelling out:
    `deno jupyter --install`
    
    Advanced installs can specify their own path:
    `deno jupyter --install --directory ~/.kernelspec_custom_location/deno`
    
    In the advanced case deno builds and installs the files directly rather
    than relying on calling out to jupyter to determine path.
    
    This is useful in the circumstance where jupyter is not on PATH at time
    of installing deno jupyter, but it is available and used via a wrapping
    library.
    zph committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6404a39 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. WIP

    zph committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5286f0a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Change directory to dir flag

    zph committed May 6, 2024
    Configuration menu
    Copy the full SHA
    33ac036 View commit details
    Browse the repository at this point in the history
  2. Revert "WIP"

    This reverts commit 5286f0a.
    zph committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2da9f56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5094e0 View commit details
    Browse the repository at this point in the history
  4. Update cli/tools/jupyter/install.rs

    Co-authored-by: Bartek Iwańczuk <[email protected]>
    Signed-off-by: Zander Hill <[email protected]>
    zph and bartlomieju committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8291a8b View commit details
    Browse the repository at this point in the history