feat(cli/tools/jupyter) Add --directory flag to control where jupyter kernelspec installs #23595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20744
Adds ability to specify the kernelspec location for deno's jupyter kernel during install with --directory flag without the requirement of having Jupyter binary on the PATH.
Advanced installs can specify their own path:
deno jupyter --install --dir ~/.kernelspec_custom_location/deno
(Edited from directory -> dir)
Standard installs continue with default behavior by installing in user's kernelspec folder via jupyter shelling out:
deno jupyter --install
In the advanced case deno builds and installs the files directly rather than relying on calling out to jupyter to determine path.
This is useful in the circumstance where jupyter is not on PATH at time of installing deno jupyter, but it is available and used via a wrapping library.
Action Items
cargo test
passes../tools/format.js
passes without changing files../tools/lint.js
passes.all steps, but you can add '[ci]' to a commit message to force it to.
If you would like to run the benchmarks on the CI, add the 'ci-bench' label.