-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(formErrorHeader), [Point of Contact] Field-level Errors Update, [All Forms] Field-Level Errors and Header Errors content pass #566
Conversation
…d error header messages implemented
@@ -59,15 +59,21 @@ function UpdateAffiliateInformation({ | |||
setValueAs: processRssdId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can comment this to enable character input into the RSSD, Parent RSSD ID and Top holder RSSD ID fields.
…essages into its own file
…into 483-design-review-poc-and-formerrorheader-refactor
…into 483-design-review-poc-and-formerrorheader-refactor
…nge the alert heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling yet another complex and wide-reaching improvement! Can't say I tested every bit but POC and Update financial profile pages look good to me.
closes #451 closes #483 closes #555 closes #554 ### Note: Will include all of the changes #566 after that PR has been approved ## Changes - content(contact): updated content based on figma - [refactor(contact link): utilizes the RegulationB in commonLinks](1aa20bb) - [content(contact): updated states.json to include states abbrev](f071c8a) - [feat(contact): input error styling](8e60e78) - [feat(contact): states and territories now come from a fetched endpoint](17eb4ab) --------- Co-authored-by: Meis <[email protected]>
closes #553
closes #562
closes #569
closes #532
Field level errors and form error header messages matching the figma's
Changes
-- select option --
in the states selectionHow to Test
Screenshots (Updated 05/23/2024)
Note: Small content updates are present but not shown in the screenshots