Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formErrorHeader), [Point of Contact] Field-level Errors Update, [All Forms] Field-Level Errors and Header Errors content pass #566

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented May 22, 2024

closes #553
closes #562
closes #569
closes #532

Field level errors and form error header messages matching the figma's

  • Complete Your User Profile
  • Complete Your User Profile (No Assoc)
  • Point of Contact
  • Types of Financial Institutions
  • Update your Financial Profile

Changes

  • chore(Point of Contact): Removed the -- select option -- in the states selection
  • refactor(formErrorHeader): changed the component (used in all forms) to be more flexible
  • content(formErrorHeader): made a content pass to the field level errors and header error messages

How to Test

  • Test every form and every input field, select or checkbox
  • Compare with the figma

Screenshots (Updated 05/23/2024)

Note: Small content updates are present but not shown in the screenshots

Complete Your Profile Complete Your Profile (No Assoc)
Screenshot 2024-05-23 at 4 22 37 PM Screenshot 2024-05-23 at 4 19 09 PM
Point of Contact A Point of Contact B
Screenshot 2024-05-23 at 5 01 34 PM Screenshot 2024-05-23 at 5 06 27 PM
Types of Financial Institutions A Types of Financial Institutions B
Screenshot 2024-05-23 at 4 39 34 PM Screenshot 2024-05-23 at 4 39 49 PM
Update Financial Profile A Update Financial Profile B Update Financial Profile C Update Financial Profile D
Screenshot 2024-05-23 at 4 03 29 PM Screenshot 2024-05-23 at 4 03 39 PM Screenshot 2024-05-23 at 4 03 45 PM Screenshot 2024-05-23 at 4 03 54 PM

@shindigira shindigira marked this pull request as draft May 22, 2024 19:54
@shindigira shindigira changed the base branch from main to 483-design-review-poc May 22, 2024 19:54
@shindigira shindigira changed the title refactor(formErrorHeader) refactor(formErrorHeader) & [Point of Contact] Field-level Errors Update May 22, 2024
@shindigira shindigira marked this pull request as ready for review May 23, 2024 04:04
@@ -59,15 +59,21 @@ function UpdateAffiliateInformation({
setValueAs: processRssdId,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can comment this to enable character input into the RSSD, Parent RSSD ID and Top holder RSSD ID fields.

@shindigira shindigira changed the title refactor(formErrorHeader) & [Point of Contact] Field-level Errors Update refactor(formErrorHeader), [Point of Contact] Field-level Errors Update, [All Forms] Field-Level Errors and Header Errors content pass May 23, 2024
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling yet another complex and wide-reaching improvement! Can't say I tested every bit but POC and Update financial profile pages look good to me.

@shindigira shindigira merged commit c107af1 into 483-design-review-poc May 24, 2024
shindigira added a commit that referenced this pull request May 28, 2024
closes #451 
closes #483 
closes #555
closes #554 

### Note: Will include all of the changes
#566 after that PR has been
approved

## Changes
- content(contact): updated content based on figma
- [refactor(contact link): utilizes the RegulationB in
commonLinks](1aa20bb)
- [content(contact): updated states.json to include states
abbrev](f071c8a)
- [feat(contact): input error
styling](8e60e78)
- [feat(contact): states and territories now come from a fetched
endpoint](17eb4ab)

---------

Co-authored-by: Meis <[email protected]>
@billhimmelsbach billhimmelsbach deleted the 483-design-review-poc-and-formerrorheader-refactor branch May 31, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Point of Contact] Field-level Errors Update FormErrorHeader - Needs to be refactored to be flexibile
2 participants