Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Review - Point of Contact #548

Merged
merged 80 commits into from
May 28, 2024
Merged

Design Review - Point of Contact #548

merged 80 commits into from
May 28, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented May 20, 2024 •
edited

@shindigira shindigira marked this pull request as draft May 20, 2024 22:31
shindigira and others added 22 commits May 20, 2024 20:45
@shindigira
content(contact): updated text
61c67d9
@shindigira
refactor(contact link): utilizes the RegulationB in commonLinks
1aa20bb
@shindigira
refactor(getZodKeys): import updates
4a25256
@shindigira
Merge branch 'main' of github.com:cfpb/sbl-frontend into 483-design-r…
e2b64e2 
…eview-poc
@shindigira
content(contact): updated states.json to include states abbrev
f071c8a
@shindigira
chore(routes - poc): commented out unused route
afa44a5
@shindigira
enhancement(poc): updated layout
4aec735
@shindigira
content(poc): states updated with 6 us territories
a4c4051
@shindigira
TODO comment
c65c671
@shindigira
conflict
75dbf88
@shindigira
TODO: fix 'isDirty'
cb74dae
@shindigira
feat(contact): added additional text to zip code and phone number
0d68f3e
@shindigira
content(contact): State or territory
626c085
@shindigira
feat(contact): Added success alert if previously submitted poc was su…
d361f39 
…ccessful
@shindigira
comment
a0aaf37
@meissadia
fix: [Point of Contact] Recognize isDirty when changing State input
e245365
@shindigira
feat(contact): input error styling
8e60e78
@shindigira
Merge branch '483-design-review-poc' of github.com:cfpb/sbl-frontend …
88d0f6a 
…into 483-design-review-poc
@shindigira
reinstated isDirty
53220c7
@shindigira
chore(contact): disable success alert on 'clear form'
f19e2e1
@shindigira
chore(contact):flipped order of phone and email in error header
51fbf52
@shindigira
Merge branch 'main' of github.com:cfpb/sbl-frontend into 483-design-r…
d768bb8 
…eview-poc
meissadia
meissadia requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple code cleanup items, one bug fix, and one verification of error messaging - but you've made lots of progress here.

src/App.tsx Outdated Show resolved Hide resolved
src/pages/Filing/FilingApp/FilingContact.tsx Outdated Show resolved Hide resolved
src/index.css Show resolved Hide resolved
src/pages/PointOfContact/index.tsx Show resolved Hide resolved
src/pages/PointOfContact/index.tsx Show resolved Hide resolved
src/pages/PointOfContact/index.tsx Show resolved Hide resolved
src/types/formTypes.ts Outdated Show resolved Hide resolved
@shindigira
refactor(formErrorHeader), [Point of Contact] Field-level Errors Upda…
c107af1 
…te, [All Forms] Field-Level Errors and Header Errors content pass (#566)

closes #553 
closes #562 
closes #569 
closes #532

### Field level errors and form error header messages matching the
figma's
- [x] Complete Your User Profile 
- [x] Complete Your User Profile (No Assoc) 
- [x] Point of Contact
- [x] Types of Financial Institutions
- [x] Update your Financial Profile

## Changes
- chore(Point of Contact): Removed the `-- select option --` in the
states selection
- refactor(formErrorHeader): changed the component (used in all forms)
to be more flexible
- content(formErrorHeader): made a content pass to the field level
errors and header error messages

## How to Test
- Test every form and every input field, select or checkbox
- Compare with the figma

## Screenshots (Updated 05/23/2024)
### Note: Small content updates are present but not shown in the
screenshots

| Complete Your Profile | Complete Your Profile (No Assoc) |
|--|--|
|<img width="271" alt="Screenshot 2024-05-23 at 4 22 37 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/700cb925-04a5-4c41-80de-62557c18519a">|<img
width="271" alt="Screenshot 2024-05-23 at 4 19 09 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/19354d1e-bbcc-47b0-89a3-c59439979c65">|


| Point of Contact A | Point of Contact B |
|--|--|
|<img width="273" alt="Screenshot 2024-05-23 at 5 01 34 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/98ad9c57-94cd-4581-be7d-c951bda5d2a7">|<img
width="260" alt="Screenshot 2024-05-23 at 5 06 27 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/3b2b2e24-6ef3-4d59-a6fb-337e21f88f79">|



| Types of Financial Institutions A | Types of Financial Institutions B
|
|--|--|
|<img width="478" alt="Screenshot 2024-05-23 at 4 39 34 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/40c63aa3-fe22-40f9-9712-8153aad07dd5">|<img
width="481" alt="Screenshot 2024-05-23 at 4 39 49 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/42052ce4-124b-4c9f-bc3c-8e15cb5c25bb">|

| Update Financial Profile A | Update Financial Profile B | Update
Financial Profile C | Update Financial Profile D |
|--|--|--|--|
|<img width="530" alt="Screenshot 2024-05-23 at 4 03 29 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/5d1f667e-d686-4090-8001-fa4b03f743bb">|<img
width="528" alt="Screenshot 2024-05-23 at 4 03 39 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/e3cea4b4-983f-43c8-80c9-21d1871b3cf5">|<img
width="529" alt="Screenshot 2024-05-23 at 4 03 45 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/b146da17-7a95-49f2-938f-455bdb409947">|<img
width="402" alt="Screenshot 2024-05-23 at 4 03 54 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/b7991104-076e-4500-b35a-f69fb76967ea">|
@shindigira
Merge branch '483-design-review-poc-and-formerrorheader-refactor' of …
aa83a09 
…github.com:cfpb/sbl-frontend into 483-design-review-poc
@shindigira
resolvedmerge conflicts
e9b775f
@shindigira shindigira requested a review from meissadia May 25, 2024 04:08
meissadia
meissadia approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@shindigira shindigira merged commit be846d8 into main May 28, 2024
4 checks passed
@billhimmelsbach billhimmelsbach deleted the 483-design-review-poc branch May 31, 2024 14:44
@shindigira shindigira mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shindigira @meissadia