Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type of FI] Update page content #543

Merged
merged 22 commits into from
May 29, 2024
Merged

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented May 20, 2024

Close #532

This PR has transformed into a few smaller header updates and some code cleanup:

  • Update institution (section header)
    Screenshot 2024-05-28 at 1 54 17 PM
  • Provide type of financial institution (header)
    screencapture-localhost-8899-institution-123456789TESTBANK123-type-2024-2024-05-28-13_59_27

@meissadia meissadia marked this pull request as ready for review May 21, 2024 16:49
@meissadia
Copy link
Collaborator Author

Updated spacing between other and helper text
Screenshot 2024-05-22 at 12 56 17 PM

@shindigira
Copy link
Contributor

@meissadia Unintentionally and coincidentally, I included all the changes from this PR and integrated in my PR: #566 since I was overhauling the Error header with content passes.

Please check that PR and see if we can close this PR.

@meissadia meissadia changed the base branch from main to 483-design-review-poc-and-formerrorheader-refactor May 24, 2024 17:52
@meissadia meissadia changed the base branch from 483-design-review-poc-and-formerrorheader-refactor to main May 24, 2024 17:54
@meissadia
Copy link
Collaborator Author

@shindigira Think I've cleaned out all the duplicated code bits.

I'm not sure what to do about FormFieldsHeaderError. Github says it's new but my local git history says it was added 9 months ago. I don't see any references references so it's probably safe to delete, but I just want to be sure I'm not over looking something.

src/types/formTypes.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just minor stuff and we can get this in.

src/types/formTypes.ts Outdated Show resolved Hide resolved
src/pages/TypesFinancialInstitutions/index.tsx Outdated Show resolved Hide resolved
@shindigira
Copy link
Contributor

@meissadia I put all of the inline errors and associated form header errors in one place -- formErrorHeader.data.ts.

Thanks for sorting through all the changes.

@meissadia meissadia requested a review from shindigira May 28, 2024 23:28
@meissadia
Copy link
Collaborator Author

@shindigira Alright, now it's looking quite clean. Thanks for the feedback!

Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meissadia meissadia merged commit 05504da into main May 29, 2024
4 checks passed
@meissadia meissadia deleted the 532-type-of-fi__update-content branch May 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of FI - Updated content
3 participants