-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Type of FI] Update page content #543
Conversation
@meissadia Unintentionally and coincidentally, I included all the changes from this PR and integrated in my PR: #566 since I was overhauling the Error header with content passes. Please check that PR and see if we can close this PR. |
@shindigira Think I've cleaned out all the duplicated code bits. I'm not sure what to do about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just minor stuff and we can get this in.
@meissadia I put all of the inline errors and associated form header errors in one place -- Thanks for sorting through all the changes. |
@shindigira Alright, now it's looking quite clean. Thanks for the feedback! |
src/pages/Filing/UpdateFinancialProfile/TypesFinancialInstitutionSection.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Close #532
This PR has transformed into a few smaller header updates and some code cleanup: