fix: [CAL-3578] [CAL-2733] Zoho calendar issues

[vachmara]

What does this PR do?

This PR addresses a bug identified in issue #12405 and builds upon the initial work done in PR #13739 by @Pritam-sd-dev.
fixes #12405
/claim #12405

The existing implementation using the free/busy endpoint was found insufficient for accurate availability checks. I've enhanced the getAvailability function to include an event check within the specified time range to ensure more reliable results.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

The fix was manually tested by adding multiple events to my Zoho calendar and verifying whether these were correctly reflected in the calendar event schedule. Future updates should include automated tests to cover these scenarios.

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• My code doesn't follow the style guidelines of this project
• I haven't added tests that prove my fix is effective or that my feature works

[vercel]

@vachmara is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[graphite-app]

Graphite Automations

"Add community label" took an action on this PR • (05/06/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[joeauyeung]

Thanks for taking this up @vachmara. This is much needed. This still needs some work but we're on the right track.

[vachmara]

@joeauyeung on it!

[joeauyeung]

Tested this with a VPN to EU servers and this works as expected. I think we should include private events when checking for availabilities and then we should be good to merge this.

As a follow up I think we have to do this for other Zoho apps right?

[vachmara]

Tested this with a VPN to EU servers and this works as expected. I think we should include private events when checking for availabilities and then we should be good to merge this.

As a follow up I think we have to do this for other Zoho apps right?

The OAuth flow indeed needs to be implemented in the two other apps. However, the getAvailability function does not seem to be useful.

Would you like me to open separate PRs to integrate the OAuth flow into the two other apps, @joeauyeung?

[joeauyeung]

Tested this with a VPN to EU servers and this works as expected. I think we should include private events when checking for availabilities and then we should be good to merge this.
As a follow up I think we have to do this for other Zoho apps right?

The OAuth flow indeed needs to be implemented in the two other apps. However, the getAvailability function does not seem to be useful.

Would you like me to open separate PRs to integrate the OAuth flow into the two other apps, @joeauyeung?

I'm working on a PR that removes unused methods from those apps so don't worry about that part. I would like to see a separate PR changing the OAuth flows of those apps as well. Thanks!

[github-actions]

This PR is being marked as stale due to inactivity.

[joeauyeung]

Changes look good to me. Thanks for again for the contribution @vachmara!