Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zoho installaltion #13739

Closed
wants to merge 5 commits into from
Closed

Conversation

Pritam-sd-dev
Copy link
Contributor

What does this PR do?

This PR fixes error that we get on zohocalender installation.

Fixes # (issue)
fixes #12955
fixes #12405

Before
https://www.loom.com/share/b82a551a2a2c4b11ad6aefdcc55104e9?sid=d2a638a4-ad7f-4670-8a77-0edab4f7c3ff
After
https://www.loom.com/share/06ad87f1c8ee4e30a44753daea034f67?sid=478e9091-9028-418e-8783-4592e94fc3d2

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Changes of this PR can be verified by installing zohocalender for different region's accounts like US, IN, EU etc

Copy link

vercel bot commented Feb 17, 2024

@Pritam-sd-dev is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 17, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar Low priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync Stale 🐛 bug Something isn't working labels Feb 17, 2024
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@Pritam-sd-dev Pritam-sd-dev changed the title Fix zoho fix: zoho installaltion Feb 17, 2024
Copy link

graphite-app bot commented Feb 17, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/28/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

A Graphite automation took an action on this PR • (02/17/24)

1 label was added based on Keith Williams's automation, 'Add community label'

Copy link
Contributor

github-actions bot commented Feb 17, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode requested a review from a team February 17, 2024 09:48
@keithwillcode keithwillcode added this to the v3.9 milestone Feb 17, 2024
@github-actions github-actions bot removed the Stale label Feb 18, 2024
@keithwillcode keithwillcode added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync labels Feb 21, 2024
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync Stale and removed Stale labels Feb 21, 2024
@keithwillcode keithwillcode removed the High priority Created by Linear-GitHub Sync label Feb 28, 2024
@graphite-app graphite-app bot requested a review from a team February 28, 2024 13:06
@github-actions github-actions bot added the Stale label Mar 4, 2024
@joeauyeung
Copy link
Contributor

Thanks for your contribution @Pritam-sd-dev. I'm reviewing your PR and I'm trying to understand how this PR would solve those issues.

From what I see the serverDomain is something we would set on our side. If the server is in the US and stays as .com how would that address the issue?

@joeauyeung
Copy link
Contributor

But what if user wants to have multiple calendars with different domain ?

That's a good point. If a user has a calendar with a different domain is that also a different Zoho account? Every time a Cal.com user goes through the Zoho OAuth flow we create a different credential so we can still store the domain data under the key field of each credential.

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added Stale and removed Stale labels Mar 23, 2024
@keithwillcode keithwillcode modified the milestones: v3.9, v4.0 Mar 27, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Apr 11, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@github-actions github-actions bot removed the Stale label Apr 16, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Apr 30, 2024
@dosubot dosubot bot modified the milestones: v4.1, v4.2 May 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024
@github-actions github-actions bot removed the Stale label May 16, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 31, 2024
@PeerRich PeerRich modified the milestones: v4.2, v4.3 Jun 3, 2024
@github-actions github-actions bot removed the Stale label Jun 4, 2024
@joeauyeung
Copy link
Contributor

Closing in favor of #14905

@joeauyeung joeauyeung closed this Jun 5, 2024
@dosubot dosubot bot modified the milestones: v4.3, v4.2 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2842] Zoho Calendar integration results in 500 server error [CAL-3578] [CAL-2733] Zoho calendar issues
5 participants