-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zoho installaltion #13739
fix: zoho installaltion #13739
Conversation
@Pritam-sd-dev is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite AutomationsA Graphite automation took an action on this PR • (02/28/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' A Graphite automation took an action on this PR • (02/17/24)1 label was added based on Keith Williams's automation, 'Add community label' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Thanks for your contribution @Pritam-sd-dev. I'm reviewing your PR and I'm trying to understand how this PR would solve those issues. From what I see the |
That's a good point. If a user has a calendar with a different domain is that also a different Zoho account? Every time a Cal.com user goes through the Zoho OAuth flow we create a different credential so we can still store the domain data under the |
This PR is being marked as stale due to inactivity. |
This PR is being marked as stale due to inactivity. |
This PR is being marked as stale due to inactivity. |
This PR is being marked as stale due to inactivity. |
Closing in favor of #14905 |
What does this PR do?
This PR fixes error that we get on zohocalender installation.
Fixes # (issue)
fixes #12955
fixes #12405
Before
https://www.loom.com/share/b82a551a2a2c4b11ad6aefdcc55104e9?sid=d2a638a4-ad7f-4670-8a77-0edab4f7c3ff
After
https://www.loom.com/share/06ad87f1c8ee4e30a44753daea034f67?sid=478e9091-9028-418e-8783-4592e94fc3d2
Type of change
How should this be tested?
Changes of this PR can be verified by installing zohocalender for different region's accounts like US, IN, EU etc