[PM-7029] Remove conditional logic for KeyRotationImprovements feature flag #4002
+11
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
==========================================
+ Coverage 37.86% 38.00% +0.13%
==========================================
Files 1192 1192
Lines 57988 57781 -207
Branches 5549 5535 -14
==========================================
Hits 21960 21960
+ Misses 34995 34788 -207
Partials 1033 1033 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
ike-kottlowski
previously approved these changes
Apr 18, 2024
jlf0dev
requested changes
Apr 22, 2024
Comment on lines
-484
to
-491
| result = await _userService.UpdateKeyAsync( | ||
| user, | ||
| model.MasterPasswordHash, | ||
| model.Key, | ||
| model.PrivateKey, | ||
| ciphers, | ||
| folders, | ||
| sends); |
There was a problem hiding this comment.
Can we remove this method too? I think this is only called here
There was a problem hiding this comment.
Now that I think about it, we also have code in the repository that needs to be removed as well. The good news is there's no actual sql, it should just be _cipherRepository.UpdateUserKeysAndCiphersAsync in both repos (assuming nothing else calls it of course)
There was a problem hiding this comment.
Nice catch! Thank you. I've removed the methods.
jlf0dev
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Removed the conditional logic for the KeyRotationImprovements feature flag now that it has been 3 releases.
Note that the flag itself is kept as defined so that old clients will still be able to act on it.
This was causing bitwarden/clients#8453 for self-hosted customers with the flag off. Rather than try to fix the issue, I elected to remove the flag as the feature has already been enabled.
See corresponding clients PR: bitwarden/clients#8816.
Before you submit
dotnet format --verify-no-changes) (required)