Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7029] Remove key-rotation-feature-flag #8816

Merged
merged 6 commits into from
May 9, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Apr 18, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Removed the key-rotation-feature-flag from clients code.

This was causing #8453 for self-hosted customers with the flag off. Rather than try to fix the issue, I elected to remove the flag as the feature has already been enabled.

See corresponding server PR: bitwarden/server#4002

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 18, 2024
@trmartin4 trmartin4 changed the title Auth/pm-7029/key-rotation-feature-flag [PM-7029] Remove key-rotation-feature-flag Apr 18, 2024
@trmartin4 trmartin4 marked this pull request as ready for review April 18, 2024 19:05
@trmartin4 trmartin4 requested review from a team as code owners April 18, 2024 19:05
@trmartin4 trmartin4 requested review from vincentsalucci, rr-bw and jlf0dev and removed request for rr-bw April 18, 2024 19:05
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.75%. Comparing base (7bb8cae) to head (e4a41ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8816      +/-   ##
==========================================
- Coverage   27.76%   27.75%   -0.01%     
==========================================
  Files        2419     2419              
  Lines       70042    70024      -18     
  Branches    13046    13042       -4     
==========================================
- Hits        19444    19435       -9     
+ Misses      49085    49077       -8     
+ Partials     1513     1512       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Logo
Checkmarx One – Scan Summary & Detailsbd93d523-7448-4fbf-8f55-4813353b4505

No New Or Fixed Issues Found

jlf0dev
jlf0dev previously approved these changes Apr 22, 2024
Copy link
Member

@jlf0dev jlf0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

vincentsalucci
vincentsalucci previously approved these changes Apr 25, 2024
Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed AC owned file 👍

@trmartin4 trmartin4 dismissed stale reviews from vincentsalucci and jlf0dev via 3f82de3 May 7, 2024 21:50
@trmartin4 trmartin4 merged commit a89e148 into main May 9, 2024
61 of 62 checks passed
@trmartin4 trmartin4 deleted the auth/pm-7029/key-rotation-feature-flag branch May 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants