fix(behavior_velocity_planner): fix uninitialized smoother param #7078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soblin
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
3 tasks
soblin
added
the
tag:run-build-and-test-differential
shmpwk
approved these changes
May 21, 2024
takayuki5168
approved these changes
May 21, 2024
soblin
force-pushed
the
fix/uninitialized-smoother-param
branch
from
4a359d8
to
7640986
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
fix/uninitialized-smoother-param
branch
from
7640986
to
8aa1edd
Compare
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#7078) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the construction of AnalyticalJerkConstrainedSmoother in behavior_velocity_planner node,
SmootherBase::setWheelBasewas not called, potentially influencing intersection module.Related links
#6915
Tests performed
this should be fixed anyway.
Notes for reviewers
Interface changes
none
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.