Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pointcloud_preprocessor): remove unnecessary functions #7058

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented May 19, 2024

Description

These is_data_layout_compatible_with_PointXYZI and is_data_layout_compatible_with_PointXYZIRADRT functions seems not be used anymore.

It is found by cppcheck:

sensing/pointcloud_preprocessor/src/utility/utilities.cpp:152:0: style: The function 'is_data_layout_compatible_with_PointXYZI' is never used. [unusedFunction]
bool is_data_layout_compatible_with_PointXYZI(const sensor_msgs::msg::PointCloud2 & input)
^
sensing/pointcloud_preprocessor/src/utility/utilities.cpp:183:0: style: The function 'is_data_layout_compatible_with_PointXYZIRADRT' is never used. [unusedFunction]
bool is_data_layout_compatible_with_PointXYZIRADRT(const sensor_msgs::msg::PointCloud2 & input)
^

Tests performed

No

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label May 19, 2024
@knzo25
Copy link
Contributor

knzo25 commented May 19, 2024

@veqcc
With the change to a new pointcloud they may still be used to notify the users that they need to migrate. As such I would prefer this PR not ti be merged in the meantime

@yukkysaito yukkysaito self-requested a review May 19, 2024 12:12
@yukkysaito
Copy link
Contributor

Currently, the point cloud format does not conform to the specifications defined by Autoware. Some developers are making changes to align with those specifications. This Pull Request will cause conflicts, so I would like to control the timing of its merge.

@veqcc
Copy link
Contributor Author

veqcc commented May 20, 2024

Thank you for your comments!!
Should I close the Pull Request?

@knzo25
Copy link
Contributor

knzo25 commented May 21, 2024

@veqcc
Sorry for the inconvenient but can you change to draft in the meantime? 🙇

@veqcc veqcc marked this pull request as draft May 21, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants