Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ssh signed commits and completed gpg signed commit work #710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dlactin
Copy link
Contributor

@dlactin dlactin commented May 11, 2024

Building upon the work done in PR 428 to add support for SSH signed commits.

Updated Documentation to include instructions and examples for adding an SSH signing key along with links to repository provider documentation for setting up commit verification.

Updated deployment to include volumes for SSH key secrets and the respective volume mounts.

@jannfis
Copy link
Contributor

jannfis commented May 16, 2024

Hey @dlactin, thanks for this PR.

I was wondering what the value-add for this would be, because Argo CD would not be able to validate those commits signed by SSH just yet?

@dlactin
Copy link
Contributor Author

dlactin commented May 16, 2024

Hey @jannfis, in our case we require signed commits on our infrastructure repositories. So we are unable to have image updater commit to any of our protected branches without this change.

Adding commit signing capability to image updater will allow verified commits to the target repo, commit validation with ArgoCD would be a bonus when that feature is available.

Screenshot 2024-05-16 at 9 34 02 AM

@jannfis
Copy link
Contributor

jannfis commented May 16, 2024

Thanks for the clarification, @dlactin. The feature makes sense to me, then. Also, I guess with Source Verification Policies hopefully coming to Argo CD, we could as well integrate verification of SSH signatures and Image Updater would already know how to do sign using SSH then.

+1 from me for this feature. Please give us some time to review.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a couple of comments, PTAL.

docs/basics/update-methods.md Outdated Show resolved Hide resolved
docs/basics/update-methods.md Show resolved Hide resolved
docs/basics/update-methods.md Outdated Show resolved Hide resolved
docs/basics/update-methods.md Outdated Show resolved Hide resolved
ext/git/writer.go Outdated Show resolved Hide resolved
ext/git/writer.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants