Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argocd-image-updater): add commit signing support #2691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dlactin
Copy link

@dlactin dlactin commented May 13, 2024

Added support for commit key signing via SSH and GPG key along with documentation updates

Relies on argoproj-labs/argocd-image-updater#710

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

…, updated README with instructions to add SSH keys for signing

Signed-off-by: Dustin Lactin <[email protected]>
@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label May 13, 2024
@yu-croco
Copy link
Collaborator

Hi @dlactin , thank you for your PR!
Since we follow upstream's manifest, so let us resume reviewing this PR when argoproj-labs/argocd-image-updater#710 is merged and released as specific version.

@mkilchhofer
Copy link
Member

Seems that it isn't part of 0.13.0 or am I wrong?

@dlactin
Copy link
Author

dlactin commented May 15, 2024

Seems that it isn't part of 0.13.0 or am I wrong?

* [chore(argocd-image-updater): Update dependency argoproj-labs/argocd-image-updater to v0.13.0 #2692](https://github.com/argoproj/argo-helm/pull/2692)

You're right, didn't quite make it into the 0.13.0 release. If the new cadence is followed I think I'll have to revisit in 3 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argocd-image-updater awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants