Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual destructors to MongoServiceAdaptor and SpanFilter #2651

Merged
merged 3 commits into from
May 26, 2024

Conversation

yozhao
Copy link
Contributor

@yozhao yozhao commented May 24, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@yozhao
Copy link
Contributor Author

yozhao commented May 24, 2024

Fix non-virtual-dtor warning or error

@yozhao
Copy link
Contributor Author

yozhao commented May 24, 2024 via email

@zyearn zyearn merged commit f81af91 into apache:master May 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants