Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

遇到一个编译问题 #2648

Closed
yozhao opened this issue May 22, 2024 · 2 comments
Closed

遇到一个编译问题 #2648

yozhao opened this issue May 22, 2024 · 2 comments

Comments

@yozhao
Copy link
Contributor

yozhao commented May 22, 2024

third_party/brpc-1.9.0/src/brpc/span.h:207:7: error: ‘class brpc::SpanFilter’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
class SpanFilter {
^~~~~~~~~~

说 SpanFilter 没有 virtual destructor。

编译标准差异导致的？
@TousakaRin
Copy link
Contributor

应该是编译器版本或者编译选项导致的，欢迎提个PR给他加上一个virtual destructor

@lorinlee
Copy link
Contributor

lorinlee commented Jun 5, 2024

fixed by #2651

@lorinlee lorinlee closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yozhao @TousakaRin @lorinlee