Resolve variadic parameters.

[serge-kvashnin]

ParameterResolver::resolveParameters() was iterating through the reflection parameters and fetching appropriate values from either named parameters or definition parameters. This meant the number of resolved arguments matched the number of reflection parameters, even if a parameter was variadic. This change adds a check for variadic parameters and adds the rest of the parameters to the args array accordingly.

[serge-kvashnin]

Solves #881

[mnapoli]

Any significant feature addition like this requires a new integration test, can you add it? I'm not sure how it behaves with the compiled container.

[serge-kvashnin]

@mnapoli You're right. Added test and handling of variadic parameter for ObjectCreationCompiler.

[mnapoli]

Why this change?

[serge-kvashnin]

https://github.com/PHP-DI/PHP-DI/actions/runs/8737105778/job/23973356335

[mnapoli]

Oh you mean that fixes master?

A bit more clarity would help here 🙂

[serge-kvashnin]

Yes, this change disables the PhpCsFixer nullable_type_declaration check, preventing the master build from failing. Since PHP 8.4 will deprecate this kind of declaration, I suggest creating a separate Issue/PR to address it. You can then decide whether to standardize on union types or the question mark operator (whichever you think is preferable).

[mnapoli]

Can you move this to DI\Test\IntegrationTest\Definitions\CreateDefinitionTest and change the signature like the other test methods to merge both tests in 1:

Suggested change

	public function testContainerWithVariadicParameters(): void
	/**
	* @dataProvider provideContainer
	*/
	public function test_with_variadics(ContainerBuilder $builder)

[serge-kvashnin]

Done 8854fe6.

[mnapoli]

This class can be moved to DI\Test\IntegrationTest\Definitions\ObjectDefinition

[serge-kvashnin]

Done 8854fe6.

[serge-kvashnin]

@mnapoli Please don't merge it yet. After digging into issues #619 and #802, and considering Ben's comment I added some edge case tests. Turns out, there are still a few things I need to work through. I'll dive deeper and get this sorted as soon as I can.

[serge-kvashnin]

Summary of changes:

1. I introduced ksort because for definitions where specific parameters are defined and not ordered, the array might look like [1 => 'bar', 0 => 'foo']. This ensures array_slice will properly fetch the rest of the variadic parameters.
2. I also made isVariadic check the first priority check so that it works properly when variadic parameters are not passed.
3. I also enhanced the ReflectionBasedAutowiring::autowire() method with iteration through defined method injections. This involves completing method injections with parameters taken from reflection but not defined explicitly (was already done for constructor). It has nothing to do with variadic parameters, but I spotted this issue when I was defining only parameter b while skipping a (which was type-hinted).

[joachim-n]

I can't comment on the code in general as I don't know this codebase at all, but I can confirm that this PR fixes #881 for me.