method injection only passes the first parameter if the method uses a splat for its parameter

[joachim-n]

If I do:

  'letters' => DI\create(Letters::class)
    ->method(
      'setLetters',
      DI\get('alpha'),
      DI\get('beta'),
    ),

and

  public function setLetters($alpha, $beta) {

then both services are passed in. But if I change the method signature to this:

  public function setLetters(...$letters) {

Then $letters is an array with only the first service.

Full test code:

<?php

require 'vendor/autoload.php';

$container = new DI\Container([
  'alpha'   => DI\create(Alpha::class),
  'beta'    => DI\create(Beta::class),
  'letters' => DI\create(Letters::class)
    ->method(
      'setLettersList',
      DI\get('alpha'),
      DI\get('beta'),
    )
    ->method(
      'setLettersSplat',
      DI\get('alpha'),
      DI\get('beta'),
    ),
]);

class Alpha {}
class Beta {}

class Letters {
  public function setLettersList($alpha, $beta) {
    dump(__METHOD__);
    dump(func_get_args());
  }

  public function setLettersSplat(...$letters) {
    // Should also get all the letters, but only gets the first one.
    dump(__METHOD__);
    dump(func_get_args());
  }
}

$letters = $container->get('letters');

[joachim-n]

ObjectCreator::injectMethodsAndProperties() seems to be correctly getting $args in both cases, which makes it look like the problem is when the method is invoked here:

            $methodReflection->invokeArgs($object, $args);

But doing that directly on the objects works properly:

$letters = new Letters();
$methodReflection = new \ReflectionMethod($letters, 'setLettersSplat');
$args = [1, 2];
$methodReflection->invokeArgs($letters, $args);

[joachim-n]

My mistake -- I got confused with $args in the loop.

This line doesn't get the complete array but only the first item:

            $args = $this->parameterResolver->resolveParameters($methodInjection, $methodReflection);

[serge-kvashnin]

@joachim-n The PR I created should fix the issue you mentioned: #883