nixos/hardware/intel: add opencl option #219657
Conversation
|
OpenCL on intel is messy, I believe this is the support table as it currently exists:
Footnotes |
|
Thanks for the table! Should we make |
|
That is probably the best approach, perhaps another option to use |
That then belongs into nixos-hardware propably. |
| config = lib.mkIf config.hardware.intel.opencl.enable { | ||
| hardware.opengl.extraPackages = with pkgs; [ | ||
| intel-compute-runtime | ||
| intel-ocl |
There was a problem hiding this comment.
Having that under video is not fully correct, as it also has parts that only use the CPU, it is more general intel hardware.
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
There was a problem hiding this comment.
@Mic92 could you rebase this and address the issues raised?
| ); | ||
| default = null; | ||
| description = '' | ||
| Select the Intel OpenCL runtime to use. Choose your runtime based on your Intel CPU/GPU generation. |
There was a problem hiding this comment.
I consider this option documentation, also it's the same amount of code to add stuff to extraPackages, this one makes it easier to discover what needs to be done to get opencl running on a given Intel CPU.
Done. Anything else? |
There was a problem hiding this comment.
LGTM, but this probably is too minimal to have its own module
I agree with NixOS/nixos-hardware#992 (comment) and I feel like small modules like this can be merged into a big and general intel module.
Description of changes
Part of NixOS/nixos-hardware#573
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)